Sed expression editing #1542
Open
Sed expression editing #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenDB
force-pushed
the
regexEditing
branch
2 times, most recently
from
2acfe89
to
9d5d813
Compare
deepbluev7
reviewed
Jul 28, 2023
deepbluev7
reviewed
Jul 28, 2023
| if (UserSettings::instance()->sedEditing() && room->edit().isEmpty()) [[unlikely]] { | ||
| // The bulk of this logic was shamelessly stolen from Neochat. Thanks to Carl Schwan for | ||
| // letting us have this :) | ||
| static const QRegularExpression sed("^s/([^/]*)/([^/]*)(/g)?$"); |
There was a problem hiding this comment.
this means there is no way to escape a / in the regex. Probably fine, but not great. Also I really like that Vim allows you to use any non-alphanumeric character as the separator. So maybe actually go with the /s/ command :)
deepbluev7
reviewed
Jul 28, 2023
Comment on lines
+488
to
+491
| if (flags == "/g") | ||
| other.replace(regex, replacement); | ||
| else | ||
| other.replace(other.indexOf(regex), regex.size(), replacement); |
There was a problem hiding this comment.
That way the first one will do \1 group replacement, the other one won't.
The proper solution is probably to extract the first match and only do a replace on that, then stitch it back together. The regex.size() also is wrong, since it will behave incorrectly with /s/.*// imo.
There was a problem hiding this comment.
I'm not sure that I understand what you are saying here. Could you elaborate?
There was a problem hiding this comment.
- If you do a replacement with
s/.*//, I think your code will just delete 2 characters at the start of the message. - If you do a replacement like
s/[abc]*/__\1__/the first one will replaceaaacbbbaaawith__aaacbbbaaa__, the second one will replace it with the literal text__\1__, I think.
This reuses the Neochat code to edit your most recent message by sed expressions, but if you reply to one of your messages, it will try to edit that message instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reuses the Neochat code to edit your most recent message by sed expressions, but if you reply to one of your messages, it will try to edit that message instead. Also, nheko is smarter and won't blindly apply a sed expression to a message that it won't change.